Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds business metrics for credential providers #5814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cenedhryn
Copy link
Contributor

Motivation and Context

Tracking how credentials were resolved

Modifications

  • Adds a number of new business metrics feature IDs representing credential sources
  • Changes existing providerNames to the new metrics values
  • Adds more combinations and sources of credential providers
  • Introduces a new public API param source on some builders for credential providers. It's the only non-trivial way to link more than one metrics value together

Deviations from specs:

  • Not using SSO legacy u because it doesn't make sense - It's already tracked as legacy via theCREDENTIALS_PROFILE_SSO_LEGACY t value. Once in the SSO provider legacy doesn't really matter. The regular CREDENTIALS_PROFILE_SSO value of s can be used for both cases. You can't really set a legacy client without coming from the profile
  • Not tracking the exact parent provider for source profile and/or named provider / credential_source use cases. The method (source profile or named provider) is tracked in both the source provider call and the final credential provider call, but the final credential provider call will not emit exactly what the source provider was. For instance, if named provider with IMDS is used, we should track p,0 for the imds call and p,0,i for the credential metrics: named provider followed by imds followed by assume role. Instead, we'll have p,0 and p,i for the imds call and the assume roll call respectively.
  • Not tracking named provider where the source provider is env vars provider. It's an unusual case and doesn't warrant rewriting the provider.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@cenedhryn cenedhryn requested a review from a team as a code owner January 21, 2025 07:01
@cenedhryn cenedhryn force-pushed the salande/ua-business-metrics-creds branch from 593ec00 to 73242f0 Compare January 21, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant