[WIP] Buffer if custom content provider stream #5829
Closed
+75
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Jan 27, 2025
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/awssdk/core/internal/sync/BufferingContentStreamProvider.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
from
f26c702 to
c02811d
Compare
dagnir
commented
Jan 28, 2025
.../src/main/java/software/amazon/awssdk/core/internal/sync/BufferingContentStreamProvider.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
3 times, most recently
from
f884136 to
adc7934
Compare
dagnir
changed the title
zoewangg
reviewed
Jan 28, 2025
.../test/java/software/amazon/awssdk/core/internal/sync/BufferingContentStreamProviderTest.java
Outdated
Show resolved
Hide resolved
.../test/java/software/amazon/awssdk/core/internal/sync/BufferingContentStreamProviderTest.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/sync/RequestBody.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
from
adc7934 to
60cf4c4
Compare
zoewangg
previously approved these changes
Jan 28, 2025
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
from
60cf4c4 to
097b1bc
Compare
millems
reviewed
Jan 28, 2025
.../src/main/java/software/amazon/awssdk/core/internal/sync/BufferingContentStreamProvider.java
Outdated
Show resolved
Hide resolved
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
from
097b1bc to
cd9e983
Compare
millems
previously approved these changes
Jan 28, 2025
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
6 times, most recently
from
e098b11 to
55b8c4a
Compare
dagnir
changed the title
dagnir
changed the title
This updates the `RequestBody.fromContentProvider()` methods such that the underlying implementation will buffer the contents of the stream in memory during the first pass through the stream.
dagnir
force-pushed
the
dongie/buffer-content-provider
branch
from
053ce86 to
a6796ab
Compare
|
|
Superceded by other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This updates the
RequestBody.fromContentProvider()methods such that theunderlying implementation will buffer the contents of the stream in memory
during the first pass through the stream.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License