Buffer if content provider provided w/o len #5837
Merged
+255
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the `RequestBody.fromContentProvider(ContentProvider, String)` method such that the underlying implementation will buffer the contents of the stream in memory during the first pass through the stream.
zoewangg
approved these changes
Jan 29, 2025
|
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Jan 29, 2025
Merge in public PR #5837 for release
dagnir
added a commit
that referenced
this pull request
Jan 29, 2025
This updates the `RequestBody.fromContentProvider(ContentStreamProvider,long,String)` override such that the underlying implementation will buffer the contents of the stream in memory during the first pass through the stream. This is a followup to #5837.
12 tasks
dagnir
added a commit
that referenced
this pull request
Jan 29, 2025
This updates the `RequestBody.fromContentProvider(ContentStreamProvider,long,String)` override such that the underlying implementation will buffer the contents of the stream in memory during the first pass through the stream. This is a followup to #5837.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Buffer if custom content provider stream This updates the `RequestBody.fromContentProvider(ContentStreamProvider,long,String)` override such that the underlying implementation will buffer the contents of the stream in memory during the first pass through the stream. This is a followup to #5837. * Review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
RequestBody.fromContentProvider(ContentProvider, String)method such that the underlying implementation will buffer the contents of the stream in memory during the first pass through the stream.Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License