-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: S3 add an option to enable/disable "Expect: 100-continue" headers #2780
feat: S3 add an option to enable/disable "Expect: 100-continue" headers #2780
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2780 +/- ##
==========================================
+ Coverage 96.91% 96.91% +<.01%
==========================================
Files 293 293
Lines 8805 8808 +3
Branches 1651 1652 +1
==========================================
+ Hits 8533 8536 +3
Misses 272 272
Continue to review full report at Codecov.
|
@ThomasVille Looks like the email address in the git config for this PR is not registered with GitHub. |
Co-Authored-By: Trivikram Kamat <[email protected]>
Co-Authored-By: AllanFly120 <[email protected]>
27c1b2c
to
8a30bba
Compare
@trivikr I tried overriding the history of the branch with my registered email address by rebasing then amending my own commits however it seems that I now appear as the commiter of all the commits of the Is this an issue? |
Yup, PR shows conflicts need to be resolved. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Since #437, when using Riak-CS v2.1.1 as backend, uploading files larger than 1MB using streams on NodeJS leads to corrupted data stored in Riak-CS.
This PR adds an option to prevent the
Expect: 100-continue
header from being added to the content of the file when uploading a large file.Fixes basho/riak_cs#1327.
Checklist
npm run test
passes.d.ts
file is updatednpm run add-change
bundle exec rake docs:api
and inspectdoc/latest/index.html
if documentation is changedrunnpm run integration
if integration test is changed