Skip to content

Commit

Permalink
test(flaky): skip all performance tests. (#6459)
Browse files Browse the repository at this point in the history
## Problem
#6117
#6457

These issues keep popping up, regardless of the the thresholds. The
performance tests are causing more problems then they are solving. Real
performance regressions would be captured in telemetry.

## Solution
skip all performance tests, revisit once there is less flakiness. 

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
  • Loading branch information
Hweinstock authored Jan 31, 2025
1 parent 349fe04 commit 82cae41
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/core/src/shared/performance/performance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@ export function performanceTest<TSetup, TExecute>(
const testOption = options[process.platform as 'linux' | 'darwin' | 'win32']

const totalTestRuns = options.testRuns ?? 10

return describe(`${name} performance tests`, () => {
// TODO: unskip this once flakiness is reduced.
return describe.skip(`${name} performance tests`, () => {
let performanceTracker: PerformanceTracker | undefined
const testRunMetrics: PerformanceMetrics[] = []

Expand Down

0 comments on commit 82cae41

Please sign in to comment.