Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(amazonq): Removing flaky test case in generateZipTestGen function #6482

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

laileni-aws
Copy link
Contributor

Problem

Solution

  • Not able to reproduce this in local machine. Double checked with team and planned to disable this test for now to avoid hassle for partner teams.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws changed the title perf(AmazonQ): Removing Flaky test case in generateZipTestGen perf(amazonq): Removing Flaky test case in generateZipTestGen Feb 1, 2025
@laileni-aws laileni-aws changed the title perf(amazonq): Removing Flaky test case in generateZipTestGen perf(amazonq): Removing flaky test case in generateZipTestGen function Feb 1, 2025
@laileni-aws laileni-aws closed this Feb 1, 2025
@laileni-aws laileni-aws reopened this Feb 1, 2025
@laileni-aws laileni-aws marked this pull request as ready for review February 1, 2025 02:06
@laileni-aws laileni-aws requested a review from a team as a code owner February 1, 2025 02:06
@Hweinstock
Copy link
Contributor

If you plan on potentially re-enabling would it be easier to skip for now, rather than delete?

@laileni-aws
Copy link
Contributor Author

If you plan on potentially re-enabling would it be easier to skip for now, rather than delete?

As this is causing hassle for other Q teams in CI so, team decided to delete for now and add it back later when its stable.

@laileni-aws laileni-aws merged commit 8533cf8 into aws:master Feb 4, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants