Add explanation for why Cluster Autoscaler should not be used in conj… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unction with a single multi-Z ASG.
nrdlngr
reviewed
Nov 6, 2019
| @@ -148,6 +148,15 @@ If you do not provide a keypair here, the AWS CloudFormation stack creation fail | |||
| ``` | |||
|
|
|||
| 1. Open the file with your favorite text editor\. Replace the *<ARN of instance role \(not instance profile\)>* snippet with the **NodeInstanceRole** value that you recorded in the previous procedure, and save the file\. | |||
|
|
|||
There was a problem hiding this comment.
It looks like this section accidentally slipped in from #68. Can you remove this section from this PR or close the other one?
|
@parijatmishra Sorry this has been open so long. I think your initial concern with the autoscaler is now addressed in the autoscaler doc. If so, please close this PR. If not, let me know what you think is still missing. Thank you. |
|
Closing this since I believe it's been resolved and I haven't heard back from @parijatmishra. Feel free to re-open if you don't believe it has been resolved. Thank you for using Amazon EKS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unction with a single multi-Z ASG.
This is pertinent because some people may have previously encountered eksworkshop.com docco for Cluster AutoScaler which uses just one multi-AZ ASG, and may be curious about which advice is correct and why.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.