Update RestXML error

awslabs · Jan 27, 2024 · e638413 · e638413
1 parent 90ffa69
commit e638413
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/Sources/Core/AWSClientRuntime/Errors/RestXMLError+AWS.swift b/Sources/Core/AWSClientRuntime/Errors/RestXMLError+AWS.swift
@@ -4,6 +4,7 @@
  */
 
 import ClientRuntime
+import class SmithyXML.Reader
 
 extension RestXMLError {
     /// Makes a `RestXMLError` from the provided `HttpResponse`.
@@ -15,13 +16,13 @@ extension RestXMLError {
     /// - Returns: A`RestXMLError` instance with an error code of "NotFound" if the response body is empty and the status code is 404. Otherwise returns a `RestXMLError` by calling ``RestXMLError.init(httpResponse: HttpResponse)``.
     ///
     /// - Throws: An error if it fails to decode the response body.
-//    public static func makeError(from httpResponse: HttpResponse, reader: SmithyXML.Reader) async throws -> RestXMLError {
-//        response.statusCodeIsNotFoundAndBodyIsEmpty
-//            ? .makeNotFoundError(requestID: response.requestId)
-//            : try await .init(reader, )
-//    }
-//
-//    static func makeNotFoundError(requestID: String?) -> RestXMLError {
-//        return RestXMLError(code: "NotFound", type: "Sender", requestID: requestID)
-//    }
+    public static func makeError(from httpResponse: HttpResponse, reader: SmithyXML.Reader) async throws -> RestXMLError {
+        httpResponse.statusCodeIsNotFoundAndBodyIsEmpty
+            ? .makeNotFoundError(requestID: httpResponse.requestId)
+            : try await .init(responseReader: <#T##Reader#>, noErrorWrapping: <#T##Bool#>)
+    }
+
+    static func makeNotFoundError(requestID: String?) -> RestXMLError {
+        return RestXMLError(code: "NotFound", message: "404 Not Found", requestID: requestID)
+    }
 }