Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customizations #1221

Merged
merged 11 commits into from
Jan 9, 2024
Prev Previous commit
Update comment to be more specific.
Sichan Yoo committed Nov 16, 2023
commit 828f3a32233766f52dfb82371ab1a86bef6f4c5f
Original file line number Diff line number Diff line change
@@ -93,7 +93,8 @@ class RulesBasedAuthSchemeResolverGenerator {
// SigV4A case
write("case .sigV4A(let param):")
indent()
// sigv4a trait is not yet implemented, this is a customization until the trait is added.
// sigv4a trait is not yet implemented by Smithy
// This is a SDK-level customization until the trait is added
write("var sigV4Option = AuthOption(schemeID: \"${SigV4Trait.ID}a\")")
write("sigV4Option.signingProperties.set(key: AttributeKeys.signingName, value: param.signingName)")
write("sigV4Option.signingProperties.set(key: AttributeKeys.signingRegion, value: param.signingRegionSet?[0])")