feat!: SRA Identity & Auth #1343

sichanyoo · 2024-02-10T00:54:42Z

Issue #

Release milestone ticket: #1149
Project ticket: #1119

Description of changes

Reworks Swift SDK's Identity & Auth flows to be SRA compliant (aka easily extensible).

Changes are in three categories:

Runtime swift library used by codegen & runtime.
Codegen changes that generate new files (e.g., AuthSchemeResolver).
Tests. Both swift tests and kotlin tests are added.

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…cols in smithy-swift (#1150) * Refactor existing structure to use new identity protocols in smithy-swift. --------- Co-authored-by: Sichan Yoo <[email protected]>

…#1167) * Add signer changes. --------- Co-authored-by: Sichan Yoo <[email protected]>

* Add signer changes. --------- Co-authored-by: Sichan Yoo <[email protected]>

* Add signing properties customization hook implementation to sigv4 auth scheme, used via polymorphism in AuthSchemeMiddleware. --------- Co-authored-by: Sichan Yoo <[email protected]>

* Replace SigV4Middleware with SigningMiddleware for normal request signing flow codegen, add in auth scheme resolver generator and auth scheme middleware usage to codegen flow, and add auth schem and auth scheme resolver to service specific config construction call. * Update test cases to include auth schemes & auth scheme resolver in middleware context construction, and to include auth scheme middleware and signer middleware in operation stack. * Update sdkId source. * Move region in middleware context from sdk to smithy. * Make auth scheme resolver associated type of service specific config oject. * Move auth schemes from service specific config to general AWS config. --------- Co-authored-by: Sichan Yoo <[email protected]>

* chore!: Require Swift 5.7, fix deprecation warnings (#1173) * feat: support initial-response in RPC based event streams (#1165) * chore: bump models (#1178) Co-authored-by: Sichan Yoo <[email protected]> * chore: Updates version to 0.28.0 * add visionOS support to useragent (#1182) * chore: Remove all models before copying in latest versions (#1185) * chore: update models (#1187) * chore: Update to aws-crt-swift 0.15.0 (#1188) * chore: Updates version to 0.29.0 * chore: Update swiftlint to 0.53.0 (#1192) * chore: End the SDK package manifest with a newline (#1203) * fix: Update CRT dependency to 0.17.0 (#1210) * chore: Updates version to 0.30.0 * chore: Clean up unnecessary TODOs + move test functions to a better location (#1209) * feat: expose presign / presignURL methods in Models.swift to service client object (#1198) * Add codegen to expose presign / presignURL methods on service client object. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Bump models in prep for release 0.31.0 (#1218) * chore: Updates version to 0.31.0 * fix: add s3 control to list of service clients that should have useSignedBodyHeader (#1219) --------- Co-authored-by: Josh Elkins <[email protected]> Co-authored-by: David Yaffe <[email protected]> Co-authored-by: Sichan Yoo <[email protected]> Co-authored-by: AWS SDK Swift Automation <[email protected]>

* Add customizations to auth resolve process. Rules-based auth scheme resolver work wrap-up. Wrap-up rules-based resolver customization and presign / presign-url flow refactors. Refactor eventstream signing. Update test cases to include auth schemes & auth scheme resolver in middleware context construction, and to include auth scheme middleware and signer middleware in operation stack. Move requestSignature getter, setter, and attribute key to generic middleware context in smithy-swift. Update event stream test cases. Move setting signing algorithm property from auth scheme resolver to auth scheme customization hook. Add necessary enum import for rules based auth scheme resolver codegen. Add codegen test for rules based auth scheme resolver generation. * Refactor setUpBidirectionalStreaming in HttpContext extension to make it more readable. * Add SigV4Util and refactor signing properties customization of SigV4 and SigV4A AuthSchemes to make it more scalable. * Refactor eventstream message signing to accept any custom signer that conforms to ClientRuntime.Signer protocol. --------- Co-authored-by: Sichan Yoo <[email protected]>

* chore!: Require Swift 5.7, fix deprecation warnings (#1173) * feat: support initial-response in RPC based event streams (#1165) * chore: bump models (#1178) Co-authored-by: Sichan Yoo <[email protected]> * chore: Updates version to 0.28.0 * add visionOS support to useragent (#1182) * chore: Remove all models before copying in latest versions (#1185) * chore: update models (#1187) * chore: Update to aws-crt-swift 0.15.0 (#1188) * chore: Updates version to 0.29.0 * chore: Update swiftlint to 0.53.0 (#1192) * chore: End the SDK package manifest with a newline (#1203) * fix: Update CRT dependency to 0.17.0 (#1210) * chore: Updates version to 0.30.0 * chore: Clean up unnecessary TODOs + move test functions to a better location (#1209) * feat: expose presign / presignURL methods in Models.swift to service client object (#1198) * Add codegen to expose presign / presignURL methods on service client object. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Bump models in prep for release 0.31.0 (#1218) * chore: Updates version to 0.31.0 * fix: add s3 control to list of service clients that should have useSignedBodyHeader (#1219) * update SQS to latest model that uses aws json protocol + add integration test (#1233) * fix: Fix tests related to operation doc header (#1231) * fix: Codegen issues re: recursion, Swift keywords in unions (#1237) * fix: Integration test crashes on failure, build warning (#1239) * feat!: Replace the XML encoder with a custom Smithy implementation (#1224) * chore: Modernize the codegen-build-test CI workflow (#1240) * chore: Modernize the codegen-build-test-on-comment CI workflow (#1243) * fix: Fix ref used for smithy-swift checkout in codegen-build-test-on-comment (#1244) * feat!: Use closures for processing HTTP response (#1242) * add IsTruncated pagination customization for S3 ListParts (#1245) * feat: Publish documentation to public distribution (#1232) * fix: Fix script for extracting version from GH ref (#1247) * chore: Codegen dev script takes args for manifest generator (#1246) * fix: Use bash to run doc generator version step (#1248) * chore: Update models (#1252) * chore: Updates version to 0.32.0 * fix: DocC post-testing fixes (#1249) * chore: Run tvOS old & new in CI (#1253) * feat: Package manifest generator improvements (#1250) * fix: Use new manifest generator options to run protocol & unit tests in CI (#1257) * chore: remove use of HttpBody and replace with ByteStream (#1254) * fix: Remove codegen-build-test-on-comment workflow (#1262) * chore: update smithy to 1.42.0 (#1261) * feat: Add codegen-build-test workflow to pull requests (#1263) * fix: codegen-build-test with workflow dispatch & custom branch names (#1265) * fix integration tests (#1268) * chore: bump models (#1270) * chore: Updates version to 0.33.0 * fix: Batch documentation modules properly (#1274) * chore: Update to aws-crt-swift 0.20.0 (#1275) * fix: update partitions to latest fixes failing endpoints tests (#1277) * feat: handle errors in 200 response from S3 (#1266) * chore: Use Xcode 15.1 as CI latest version (#1286) * Delete unnecessary TODO item. (#1288) Co-authored-by: Sichan Yoo <[email protected]> * Update models. * feat!: Use Foundation-based HTTP client on Apple platforms (#1282) * Fix models. * Fix test cases to reflect I&A codegen changes. --------- Co-authored-by: Josh Elkins <[email protected]> Co-authored-by: David Yaffe <[email protected]> Co-authored-by: Sichan Yoo <[email protected]> Co-authored-by: AWS SDK Swift Automation <[email protected]>

* Add S3 control to list of services that use signed body & fix wrong method name in SigV4Util. --------- Co-authored-by: Sichan Yoo <[email protected]>

* chore!: Require Swift 5.7, fix deprecation warnings (#1173) * feat: support initial-response in RPC based event streams (#1165) * chore: bump models (#1178) Co-authored-by: Sichan Yoo <[email protected]> * chore: Updates version to 0.28.0 * add visionOS support to useragent (#1182) * chore: Remove all models before copying in latest versions (#1185) * chore: update models (#1187) * chore: Update to aws-crt-swift 0.15.0 (#1188) * chore: Updates version to 0.29.0 * chore: Update swiftlint to 0.53.0 (#1192) * chore: End the SDK package manifest with a newline (#1203) * fix: Update CRT dependency to 0.17.0 (#1210) * chore: Updates version to 0.30.0 * chore: Clean up unnecessary TODOs + move test functions to a better location (#1209) * feat: expose presign / presignURL methods in Models.swift to service client object (#1198) * Add codegen to expose presign / presignURL methods on service client object. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Bump models in prep for release 0.31.0 (#1218) * chore: Updates version to 0.31.0 * fix: add s3 control to list of service clients that should have useSignedBodyHeader (#1219) * update SQS to latest model that uses aws json protocol + add integration test (#1233) * fix: Fix tests related to operation doc header (#1231) * fix: Codegen issues re: recursion, Swift keywords in unions (#1237) * fix: Integration test crashes on failure, build warning (#1239) * feat!: Replace the XML encoder with a custom Smithy implementation (#1224) * chore: Modernize the codegen-build-test CI workflow (#1240) * chore: Modernize the codegen-build-test-on-comment CI workflow (#1243) * fix: Fix ref used for smithy-swift checkout in codegen-build-test-on-comment (#1244) * feat!: Use closures for processing HTTP response (#1242) * add IsTruncated pagination customization for S3 ListParts (#1245) * feat: Publish documentation to public distribution (#1232) * fix: Fix script for extracting version from GH ref (#1247) * chore: Codegen dev script takes args for manifest generator (#1246) * fix: Use bash to run doc generator version step (#1248) * chore: Update models (#1252) * chore: Updates version to 0.32.0 * fix: DocC post-testing fixes (#1249) * chore: Run tvOS old & new in CI (#1253) * feat: Package manifest generator improvements (#1250) * fix: Use new manifest generator options to run protocol & unit tests in CI (#1257) * chore: remove use of HttpBody and replace with ByteStream (#1254) * fix: Remove codegen-build-test-on-comment workflow (#1262) * chore: update smithy to 1.42.0 (#1261) * feat: Add codegen-build-test workflow to pull requests (#1263) * fix: codegen-build-test with workflow dispatch & custom branch names (#1265) * fix integration tests (#1268) * chore: bump models (#1270) * chore: Updates version to 0.33.0 * fix: Batch documentation modules properly (#1274) * chore: Update to aws-crt-swift 0.20.0 (#1275) * fix: update partitions to latest fixes failing endpoints tests (#1277) * feat: handle errors in 200 response from S3 (#1266) * chore: Use Xcode 15.1 as CI latest version (#1286) * Delete unnecessary TODO item. (#1288) Co-authored-by: Sichan Yoo <[email protected]> * feat!: Use Foundation-based HTTP client on Apple platforms (#1282) * fix integration tests to conform to latest HTTPClient change (#1295) * chore: update to CRT 0.22.0 (#1296) * chore: Update smithy-swift to 0.38.0 (#1298) * chore: Update .spi.yml (#1297) * Delete bundle region provider. (#1290) Co-authored-by: Sichan Yoo <[email protected]> * fix!: Refactor resolveRegion method name to getRegion for consistency. (#1291) * Refactor resolveRegion method name to getRegion for consistency. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Update models (#1301) * fix: Preserve data after reading response body stream in S3/200 middleware (#1303) * chore: Updates version to 0.34.0 * feat: Add integration tests to CI (#1308) * feat!: Provide HTTP request components by closure instead of protocol (#1317) * Update models with latest from main. * Add needed fix for making integration tests pass. * Fix input to private init of AWSClientConfig. --------- Co-authored-by: Josh Elkins <[email protected]> Co-authored-by: David Yaffe <[email protected]> Co-authored-by: Sichan Yoo <[email protected]> Co-authored-by: AWS SDK Swift Automation <[email protected]> Co-authored-by: Sven A. Schmidt <[email protected]>

* chore!: Require Swift 5.7, fix deprecation warnings (#1173) * feat: support initial-response in RPC based event streams (#1165) * chore: bump models (#1178) Co-authored-by: Sichan Yoo <[email protected]> * chore: Updates version to 0.28.0 * add visionOS support to useragent (#1182) * chore: Remove all models before copying in latest versions (#1185) * chore: update models (#1187) * chore: Update to aws-crt-swift 0.15.0 (#1188) * chore: Updates version to 0.29.0 * chore: Update swiftlint to 0.53.0 (#1192) * chore: End the SDK package manifest with a newline (#1203) * fix: Update CRT dependency to 0.17.0 (#1210) * chore: Updates version to 0.30.0 * chore: Clean up unnecessary TODOs + move test functions to a better location (#1209) * feat: expose presign / presignURL methods in Models.swift to service client object (#1198) * Add codegen to expose presign / presignURL methods on service client object. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Bump models in prep for release 0.31.0 (#1218) * chore: Updates version to 0.31.0 * fix: add s3 control to list of service clients that should have useSignedBodyHeader (#1219) * Add customizations to auth resolve process. Rules-based auth scheme resolver work wrap-up. Wrap-up rules-based resolver customization and presign / presign-url flow refactors. Refactor eventstream signing. Update test cases to include auth schemes & auth scheme resolver in middleware context construction, and to include auth scheme middleware and signer middleware in operation stack. Move requestSignature getter, setter, and attribute key to generic middleware context in smithy-swift. Update event stream test cases. Move setting signing algorithm property from auth scheme resolver to auth scheme customization hook. Add necessary enum import for rules based auth scheme resolver codegen. Add codegen test for rules based auth scheme resolver generation. * Fix swiftlint. * Fix swiftlint. * Refactor setUpBidirectionalStreaming in HttpContext extension to make it more readable. * Add SigV4Util and refactor signing properties customization of SigV4 and SigV4A AuthSchemes to make it more scalable. * Remove duplicate presign flag logic. * Refactor eventstream message signing to accept any custom signer that conforms to ClientRuntime.Signer protocol. * Fix swiftlint. * Fix method name in SigV4Util and update usage in auth schemes accordingly. Also, remove duplicate AttributeKey (expiration) from AWS's HttpContext extension. * Add tests for SigV4AuthScheme signing properties customization, as well as SigV4Util. * Refactor or delete deprecated signing components and tests. - Rename `AWSSigningMiddleware.kt` to `SigV4Utils.kt` and delete generator code for `SigV4Middleware`. Update companion object method calls and import statements in other files accordingly. - Refactor tests for `AWSSigningMiddlewareTests.kt` and change name to `SigV4UtilsTests.kt` to only test for companion object methods. - Delete `AWSSigningParams.kt` and all of its tests, including tests for `SigV4Configurator`. These tests have been moved to Swift side, in tests for auth schemes. * Delete SigV4Config and SigV4Middleware. * SigV4Signer tests - wip. * update SQS to latest model that uses aws json protocol + add integration test (#1233) * fix: Fix tests related to operation doc header (#1231) * fix: Codegen issues re: recursion, Swift keywords in unions (#1237) * fix: Integration test crashes on failure, build warning (#1239) * feat!: Replace the XML encoder with a custom Smithy implementation (#1224) * chore: Modernize the codegen-build-test CI workflow (#1240) * chore: Modernize the codegen-build-test-on-comment CI workflow (#1243) * fix: Fix ref used for smithy-swift checkout in codegen-build-test-on-comment (#1244) * feat!: Use closures for processing HTTP response (#1242) * add IsTruncated pagination customization for S3 ListParts (#1245) * feat: Publish documentation to public distribution (#1232) * fix: Fix script for extracting version from GH ref (#1247) * chore: Codegen dev script takes args for manifest generator (#1246) * fix: Use bash to run doc generator version step (#1248) * chore: Update models (#1252) * chore: Updates version to 0.32.0 * fix: DocC post-testing fixes (#1249) * chore: Run tvOS old & new in CI (#1253) * feat: Package manifest generator improvements (#1250) * fix: Use new manifest generator options to run protocol & unit tests in CI (#1257) * chore: remove use of HttpBody and replace with ByteStream (#1254) * fix: Remove codegen-build-test-on-comment workflow (#1262) * chore: update smithy to 1.42.0 (#1261) * feat: Add codegen-build-test workflow to pull requests (#1263) * fix: codegen-build-test with workflow dispatch & custom branch names (#1265) * fix integration tests (#1268) * chore: bump models (#1270) * chore: Updates version to 0.33.0 * fix: Batch documentation modules properly (#1274) * chore: Update to aws-crt-swift 0.20.0 (#1275) * fix: update partitions to latest fixes failing endpoints tests (#1277) * feat: handle errors in 200 response from S3 (#1266) * chore: Use Xcode 15.1 as CI latest version (#1286) * Delete unnecessary TODO item. (#1288) Co-authored-by: Sichan Yoo <[email protected]> * feat!: Use Foundation-based HTTP client on Apple platforms (#1282) * fix integration tests to conform to latest HTTPClient change (#1295) * chore: update to CRT 0.22.0 (#1296) * chore: Update smithy-swift to 0.38.0 (#1298) * chore: Update .spi.yml (#1297) * Delete bundle region provider. (#1290) Co-authored-by: Sichan Yoo <[email protected]> * fix!: Refactor resolveRegion method name to getRegion for consistency. (#1291) * Refactor resolveRegion method name to getRegion for consistency. --------- Co-authored-by: Sichan Yoo <[email protected]> * Add tests for SigV4Util::setS3SpecificFlags method. * Add do-catch to tests for changed method header. * Add in missing try keyword. * Add a way to fix a date for AWSSigV4Signer::signRequest, and add tests for AWSSigV4Signer::signRequest. * Add SigV4 x Presigned Request integration tests using STS::getCallerIdentity and S3::putObject. * Rename integration test directory and file for STS to be more specific. * Update S3ErrorWith200 middleware to fix S3XCTestCase::tearDown(). Delete tearDown() from presigned request integration test now that it is redundant. * chore: Update models (#1301) * fix: Preserve data after reading response body stream in S3/200 middleware (#1303) * chore: Updates version to 0.34.0 * Add EventStream Sigv4A integration test & add a test target dependency to Package.Base.swift. * Improve comments and variable names on the EventBridge integration test. * Update documentation comment to mention correct description of the test class. * Remove unncessary string literal in code. * Increase pause timer to prevent spurious failures. * Add SigV4A integration test that uses S3's multi-region access point. * feat: Add integration tests to CI (#1308) * Finish SigV4A integration tests that use S3 MRAP. * Add SigV4A signing flow integration test that uses CloudFrontKeyValueStore. * Fix SQS interation test that wasn't working in main branch either; client initializer needed a region specified. * Add auth scheme resolving step for convenience inits of client config in case they aren't provided. * Fix ktlint. * feat!: Provide HTTP request components by closure instead of protocol (#1317) * Address PR comments from Josh. * Update models to match ones in main branch. * Add newly necessary services to integration test sdk.properties. * Fix undefined variable. * Add conditional import for URLRequest. * Fix SigV4A EventBridge integration test. * Add time buffer between MRAP deletion completion and deleting buckets. Integ test fails in CI saying bucket has MRAP associated, but MRAP is deleted when checked in console. Perhaps attempting to delete bucket as soon as MRAP deletion completes is causing this error. * Fix data type. * Fix method used to check MRAP deletion completion from checking against a literal integer 1, to checking against list ofMRAP names existing on account. * Copy generated SDK code from feat/sra-identity-and-auth so it doesn't show up in github diff. * Address Josh's PR comments. * Fix typo on variable name. * Fix swiftlint. * Merge updated CRT version from main into feat/test-suite. --------- Co-authored-by: Josh Elkins <[email protected]> Co-authored-by: David Yaffe <[email protected]> Co-authored-by: Sichan Yoo <[email protected]> Co-authored-by: AWS SDK Swift Automation <[email protected]> Co-authored-by: Sven A. Schmidt <[email protected]>

* chore!: Require Swift 5.7, fix deprecation warnings (#1173) * feat: support initial-response in RPC based event streams (#1165) * chore: bump models (#1178) Co-authored-by: Sichan Yoo <[email protected]> * chore: Updates version to 0.28.0 * add visionOS support to useragent (#1182) * chore: Remove all models before copying in latest versions (#1185) * chore: update models (#1187) * chore: Update to aws-crt-swift 0.15.0 (#1188) * chore: Updates version to 0.29.0 * chore: Update swiftlint to 0.53.0 (#1192) * chore: End the SDK package manifest with a newline (#1203) * fix: Update CRT dependency to 0.17.0 (#1210) * chore: Updates version to 0.30.0 * chore: Clean up unnecessary TODOs + move test functions to a better location (#1209) * feat: expose presign / presignURL methods in Models.swift to service client object (#1198) * Add codegen to expose presign / presignURL methods on service client object. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Bump models in prep for release 0.31.0 (#1218) * chore: Updates version to 0.31.0 * fix: add s3 control to list of service clients that should have useSignedBodyHeader (#1219) * update SQS to latest model that uses aws json protocol + add integration test (#1233) * fix: Fix tests related to operation doc header (#1231) * fix: Codegen issues re: recursion, Swift keywords in unions (#1237) * fix: Integration test crashes on failure, build warning (#1239) * feat!: Replace the XML encoder with a custom Smithy implementation (#1224) * chore: Modernize the codegen-build-test CI workflow (#1240) * chore: Modernize the codegen-build-test-on-comment CI workflow (#1243) * fix: Fix ref used for smithy-swift checkout in codegen-build-test-on-comment (#1244) * feat!: Use closures for processing HTTP response (#1242) * add IsTruncated pagination customization for S3 ListParts (#1245) * feat: Publish documentation to public distribution (#1232) * fix: Fix script for extracting version from GH ref (#1247) * chore: Codegen dev script takes args for manifest generator (#1246) * fix: Use bash to run doc generator version step (#1248) * chore: Update models (#1252) * chore: Updates version to 0.32.0 * fix: DocC post-testing fixes (#1249) * chore: Run tvOS old & new in CI (#1253) * feat: Package manifest generator improvements (#1250) * fix: Use new manifest generator options to run protocol & unit tests in CI (#1257) * chore: remove use of HttpBody and replace with ByteStream (#1254) * fix: Remove codegen-build-test-on-comment workflow (#1262) * chore: update smithy to 1.42.0 (#1261) * feat: Add codegen-build-test workflow to pull requests (#1263) * fix: codegen-build-test with workflow dispatch & custom branch names (#1265) * fix integration tests (#1268) * chore: bump models (#1270) * chore: Updates version to 0.33.0 * fix: Batch documentation modules properly (#1274) * chore: Update to aws-crt-swift 0.20.0 (#1275) * fix: update partitions to latest fixes failing endpoints tests (#1277) * feat: handle errors in 200 response from S3 (#1266) * chore: Use Xcode 15.1 as CI latest version (#1286) * Delete unnecessary TODO item. (#1288) Co-authored-by: Sichan Yoo <[email protected]> * feat!: Use Foundation-based HTTP client on Apple platforms (#1282) * fix integration tests to conform to latest HTTPClient change (#1295) * chore: update to CRT 0.22.0 (#1296) * chore: Update smithy-swift to 0.38.0 (#1298) * chore: Update .spi.yml (#1297) * Delete bundle region provider. (#1290) Co-authored-by: Sichan Yoo <[email protected]> * fix!: Refactor resolveRegion method name to getRegion for consistency. (#1291) * Refactor resolveRegion method name to getRegion for consistency. --------- Co-authored-by: Sichan Yoo <[email protected]> * chore: Update models (#1301) * fix: Preserve data after reading response body stream in S3/200 middleware (#1303) * chore: Updates version to 0.34.0 * feat: Add integration tests to CI (#1308) * feat!: Provide HTTP request components by closure instead of protocol (#1317) * chore: Updated codegen (#1320) * chore: Remove several unneeded services from codegen for integration tests (#1316) * feat!: Eliminate service client protocols (#1322) * chore: Update generated code (#1326) * feat: add support for flexible checksums on Normal payloads (#1304) * chore: Update aws-crt-swift to 0.26.0 (#1335) * chore: Use Apple Silicon for codegen-build-test on CI (#1336) * Checkout main branch's Sources/Services/ and Tests/Services/ into chore/merge-changes-from-main. * Attempt #2. * Edit the new flexible checksum codegen test to include I&A stuff. * Add back accidentally removed list of services for new integration tests to sdk.properties. --------- Co-authored-by: Josh Elkins <[email protected]> Co-authored-by: David Yaffe <[email protected]> Co-authored-by: Sichan Yoo <[email protected]> Co-authored-by: AWS SDK Swift Automation <[email protected]> Co-authored-by: Sven A. Schmidt <[email protected]>

sichanyoo

Added informational comments to help reviewers.

sichanyoo · 2024-02-12T21:13:11Z

AWSSDKSwiftCLI/Sources/AWSSDKSwiftCLI/Resources/Package.Base.swift

+    case "AWSEventBridge":
+        additionalDependencies = ["AWSRoute53"]
+    case "AWSCloudFrontKeyValueStore":
+        additionalDependencies = ["AWSCloudFront"]


New dependencies for new integration tests added as part of the I&A rework.

sichanyoo · 2024-02-12T21:14:02Z

...Services/AWSCloudFrontKeyValueStoreIntegrationTests/CloudFrontKeyValueStoreSigV4ATests.swift

@@ -0,0 +1,89 @@
+//


Integration test that tests a normal (as opposed to presigned url or presigned request) client call for CloudFront KeyValueStore that uses SigV4A auth scheme.

Note: CloudFront KeyValueStore, EventBridge, and S3 are the only services that use SigV4A currently.

sichanyoo · 2024-02-12T21:15:02Z

IntegrationTests/Services/AWSEventBridgeIntegrationTests/EventBridgeSigV4ATests.swift

@@ -0,0 +1,121 @@
+//


Integration test that tests a normal client call for EventBridge that uses SigV4A auth scheme.

sichanyoo · 2024-02-12T21:19:15Z

IntegrationTests/Services/AWSS3IntegrationTests/S3PresignedRequestTests.swift

@@ -0,0 +1,51 @@
+//


Integration test that tests presigned request flow using S3.

This is great, because I don't think we have any other integration tests that test out presigned requests (just presigned URLs.)

sichanyoo · 2024-02-12T21:22:21Z

IntegrationTests/Services/AWSS3IntegrationTests/S3SigV4ATests.swift

@@ -0,0 +1,202 @@
+//


Integration tests that test presigned url flow, presigned request flow, and normal flow for S3 using S3 MRAP, which uses SigV4A auth scheme.

sichanyoo · 2024-02-12T23:00:51Z

...n/software/amazon/smithy/aws/swift/codegen/middleware/OperationEndpointResolverMiddleware.kt

+        // Write code that saves endpoint params to middleware context for use in auth scheme middleware when using rules-based auth scheme resolvers
+        if (AuthSchemeResolverGenerator.usesRulesBasedAuthResolver(ctx)) {
+            writer.write("context.attributes.set(key: AttributeKey<EndpointParams>(name: \"EndpointParams\"), value: endpointParams)")
+        }


Saves endpoint params that's constructed before AuthSchemeMiddleware's turn in middleware stack into the middleware context. May be used to construct auth scheme resolver parameters to pass into auth scheme resolver.

sichanyoo · 2024-02-12T23:02:53Z

...odegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/AWSSigningMiddlewareTests.kt

@@ -1,281 +0,0 @@
-/*


Tests here are either deleted or re-homed as the thing it tests is deleted & refactored.

The signing config logic tested here that are still relevant are now tested in SigV4AuthSchemeTests instead.

The tests for SigV4 utility methods are re-homed to SigV4UtilTests.kt.

sichanyoo · 2024-02-12T23:04:30Z

...t-codegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/SigV4ConfiguratorTests.kt

@@ -1,457 +0,0 @@
-/*


Tests here are deleted as the thing it tests is deleted. The signing config logic tested here that are still relevant are now tested in SigV4AuthSchemeTests instead.

sichanyoo · 2024-02-12T23:06:40Z

...ws-swift-codegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/SigV4UtilsTests.kt

@@ -0,0 +1,64 @@
+package software.amazon.smithy.aws.swift.codegen


Contains tests re-homed from AWSSigningMiddlewareTests.kt.

sichanyoo · 2024-02-12T23:07:23Z

scripts/integration-test-sdk.properties

@@ -1,2 +1,2 @@
 # Only include services needed for running integration tests


Additional services that need to be code generated for new integration tests added with this PR.

sichanyoo · 2024-02-21T17:47:46Z

...in/software/amazon/smithy/aws/swift/codegen/customizations/PresignableUrlIntegrationTests.kt

@@ -13,43 +13,6 @@ import software.amazon.smithy.swift.codegen.core.GenerationContext
 import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator



The cases tested here that have been re-homed are now tested under SigV4AuthSchemeTests.

…n integration test.

syall · 2024-02-27T23:27:37Z

Sources/Core/AWSSDKForSwift/Documentation.docc/AWSSDKForSwift.md

 ## Service Documentation


-[AWSACM](../../../../../swift/api/awsacm/latest)


Was this meant to be deleted?

syall · 2024-02-27T23:27:53Z

Tests/Core/AWSClientRuntimeTests/AWSClientConfigurationTests.swift

-import XCTest
-import AWSClientRuntime
-
-class AWSClientConfigurationTests: XCTestCase {


Was this meant to be deleted?

Yes, the AWSClientConfiguration was deleted along with the new Config changes from Andrew.

sichanyoo and others added 14 commits October 4, 2023 10:30

chore: Refactor existing identity structure to use new identity proto…

668575c

…cols in smithy-swift (#1150) * Refactor existing structure to use new identity protocols in smithy-swift. --------- Co-authored-by: Sichan Yoo <[email protected]>

feat: Move over signing flow from SigV4Middleware into AWSSigV4Signer (…

b056000

…#1167) * Add signer changes. --------- Co-authored-by: Sichan Yoo <[email protected]>

Merge branch 'main' into feat/sra-identity-and-auth

2bbf506

feat: auth scheme changes (#1174)

981f9f9

* Add signer changes. --------- Co-authored-by: Sichan Yoo <[email protected]>

feat: middleware changes (#1180)

f18ac03

* Add signing properties customization hook implementation to sigv4 auth scheme, used via polymorphism in AuthSchemeMiddleware. --------- Co-authored-by: Sichan Yoo <[email protected]>

feat: tie up some loose ends (#1300)

4069b54

* Add S3 control to list of services that use signed body & fix wrong method name in SigV4Util. --------- Co-authored-by: Sichan Yoo <[email protected]>

Merge main into feat/sra-identity-and-auth.

1699c64

sichanyoo had a problem deploying to Integration-Test February 10, 2024 00:54 — with GitHub Actions Failure

sichanyoo had a problem deploying to Codegen-Build-Test February 10, 2024 00:54 — with GitHub Actions Failure

sichanyoo had a problem deploying to Integration-Test February 10, 2024 00:54 — with GitHub Actions Failure

sichanyoo had a problem deploying to Integration-Test February 10, 2024 02:25 — with GitHub Actions Failure

sichanyoo commented Feb 12, 2024

View reviewed changes

sichanyoo requested review from jbelkins, dayaffe and syall February 12, 2024 23:20

sichanyoo commented Feb 21, 2024

View reviewed changes

Sichan Yoo added 2 commits February 21, 2024 14:07

Reflect removal of IdentityKind enum.

24a2a73

Merge main into feat/sra-identity-and-auth.

102aec1

Checkout generated SDK & Tests from main to hide from github PR diff.

e3931b8

sichanyoo had a problem deploying to Codegen-Build-Test February 27, 2024 23:05 — with GitHub Actions Failure

sichanyoo had a problem deploying to Integration-Test February 27, 2024 23:05 — with GitHub Actions Failure

Fix constructor call to Credentials() to AWSCredentialIdentity() in a…

3c8f09e

…n integration test.

sichanyoo had a problem deploying to Codegen-Build-Test February 27, 2024 23:13 — with GitHub Actions Failure

sichanyoo had a problem deploying to Integration-Test February 27, 2024 23:13 — with GitHub Actions Failure

sichanyoo temporarily deployed to Integration-Test February 27, 2024 23:13 — with GitHub Actions Inactive

sichanyoo had a problem deploying to Integration-Test February 27, 2024 23:13 — with GitHub Actions Failure

sichanyoo temporarily deployed to Integration-Test February 27, 2024 23:13 — with GitHub Actions Inactive

sichanyoo requested a review from syall February 27, 2024 23:13

syall approved these changes Feb 27, 2024

View reviewed changes

sichanyoo temporarily deployed to Integration-Test February 27, 2024 23:43 — with GitHub Actions Inactive

Include codegen output for S3 and DynamoDB clients for future reference.

429935e

sichanyoo temporarily deployed to Integration-Test February 27, 2024 23:54 — with GitHub Actions Inactive

sichanyoo temporarily deployed to Codegen-Build-Test February 27, 2024 23:54 — with GitHub Actions Inactive

sichanyoo had a problem deploying to Integration-Test February 27, 2024 23:54 — with GitHub Actions Failure

sichanyoo temporarily deployed to Integration-Test February 28, 2024 00:25 — with GitHub Actions Inactive

sichanyoo merged commit cb136c5 into main Feb 28, 2024
17 checks passed

sichanyoo deleted the feat/sra-identity-and-auth branch November 19, 2024 17:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: SRA Identity & Auth #1343

feat!: SRA Identity & Auth #1343

sichanyoo commented Feb 10, 2024 •

edited

Loading

sichanyoo left a comment •

edited

Loading

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

jbelkins Feb 27, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 12, 2024

sichanyoo Feb 21, 2024 •

edited

Loading

syall Feb 27, 2024

syall Feb 27, 2024

sichanyoo Feb 27, 2024

		@@ -0,0 +1,64 @@
		package software.amazon.smithy.aws.swift.codegen

		@@ -1,2 +1,2 @@
		# Only include services needed for running integration tests

		@@ -13,43 +13,6 @@ import software.amazon.smithy.swift.codegen.core.GenerationContext
		import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator

		## Service Documentation


		[AWSACM](../../../../../swift/api/awsacm/latest)

feat!: SRA Identity & Auth #1343

feat!: SRA Identity & Auth #1343

Conversation

sichanyoo commented Feb 10, 2024 • edited Loading

Issue #

Description of changes

New/existing dependencies impact assessment, if applicable

Conventional Commits

sichanyoo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sichanyoo Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sichanyoo commented Feb 10, 2024 •

edited

Loading

sichanyoo left a comment •

edited

Loading

sichanyoo Feb 21, 2024 •

edited

Loading