feat: add service specific AuthSchemePlugin and DefaultAWSAuthSchemePlugin #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
9dce328 to
5b32fa7
Compare
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
changed the title
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
5b32fa7 to
56d475a
Compare
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
56d475a to
db5811a
Compare
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
reviewed
Mar 6, 2024
| ) { | ||
| writer.write("self.authSchemeResolver = authSchemeResolver") | ||
| writer.write("self.authSchemes = authSchemes") | ||
| writer.write("self.awsCredentialIdentityResolver = awsCredentialIdentityResolver") |
There was a problem hiding this comment.
Q: Why is credential identity resolver part of the service specific auth scheme plugin, but not the default AWS auth scheme plugin? Is this overlap between auth scheme plugin & credential identity resolver plugin intentional?
There was a problem hiding this comment.
Is this overlap between auth scheme plugin & credential identity resolver plugin intentional?
@sichanyoo Yes, I thought they are all related Identity and authentication so I decided to group in the same plugin. (This was also what @syall suggested)
There was a problem hiding this comment.
I see. Since this makes identity resolver plugin redundant, should it be deleted?
There was a problem hiding this comment.
I think the identity resolver plugin doesn't exist in the PR anymore, but the title and description need to be updated.
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
db5811a to
d644030
Compare
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
d644030 to
320c3db
Compare
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
320c3db to
1e1bbc6
Compare
AndrewFossAWS
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
syall
approved these changes
Mar 6, 2024
AndrewFossAWS
changed the title
sichanyoo
approved these changes
Mar 6, 2024
AndrewFossAWS
force-pushed
the
runtime-plugins
branch
from
1e1bbc6 to
6fc8372
Compare
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
AndrewFossAWS
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add service specific AuthSchemePlugin and DefaultAWSAuthSchemePlugin
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.