fix: Add overwrite behavior for endpoints 2.0 for signing properties #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties field of SelectedAuthScheme resolved earlier in the middleware stack by AuthSchemeMiddleware. This overwrite happens only if an auth scheme gets resolved from endpoints, which customizes these values based on endpoint rules.
sichanyoo
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1402
Description of changes
signingNameandsigningRegionif auth scheme is resolved from the resolved endpoint and it has custom values for these.New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.