fix: Update doc generation CLI command to include AWS runtime modules #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
approved these changes
Aug 2, 2024
| try FileManager.default | ||
| .contentsOfDirectory(atPath: "Sources/Core") | ||
| .sorted() | ||
| .filter { !($0 == "AWSSDKForSwift") } // Ignore documentation module |
There was a problem hiding this comment.
nit: $0 != "AWSSDKForSwift"
There was a problem hiding this comment.
Changed as mentioned
| .contentsOfDirectory(atPath: "Sources/Core") | ||
| .sorted() | ||
| .filter { !($0 == "AWSSDKForSwift") } // Ignore documentation module | ||
| .filter { !$0.hasPrefix(".") } // Ignore .DS_Store file |
There was a problem hiding this comment.
nit: directory contents returned by FileManager also include . and ..; this filter ignores those entries too
There was a problem hiding this comment.
Removed the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1643
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.