feat: use sdk-partitions.json from trebuchet #1667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dayaffe I have reservations about performance on this, since a file must be read from disk for every API request. File system caching might minimize the hit though. This might be something we can look at once performance monitoring is in place. |
jbelkins
requested changes
Aug 9, 2024
| resources: [ | ||
| <<<<<<< HEAD | ||
| .process("Resources"), |
| case readError(String) | ||
| } | ||
|
|
||
| public class PartitionData { |
There was a problem hiding this comment.
I think if you just make this type an actor, it will enforce exclusive calls to loadAWSPartitionJSON().
We should not be using DispatchQueue & other GCD types in new code, except where necessary to interact with pre-Swift concurrency code.
There was a problem hiding this comment.
I made PartitionDataCache an actor which is used by this and removed DispatchQueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.