fix: Fix signer to allow streaming unsigned payload without checksum & add integration test #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
commented
Aug 8, 2024
IntegrationTests/Services/AWSS3IntegrationTests/S3FlexibleChecksumsTests.swift
Show resolved
Hide resolved
jbelkins
reviewed
Aug 9, 2024
IntegrationTests/Services/AWSS3IntegrationTests/S3FlexibleChecksumsTests.swift
Show resolved
Hide resolved
| @@ -256,12 +256,14 @@ public class AWSSigV4Signer: SmithyHTTPAuthAPI.Signer { | |||
| } | |||
| } | |||
|
|
|||
| // STREAMING-UNSIGNED-PAYLOAD-TRAILER | |||
| if isUnsignedBody { return .streamingUnsignedPayloadTrailer } | |||
|
|
|||
| // streaming + eligible for chunked transfer | |||
| if !checksumIsPresent { | |||
There was a problem hiding this comment.
should we reverse this if-else? Weird to have a negated condition for an if-else
There was a problem hiding this comment.
this whole if-else can now break down to one statement BTW
There was a problem hiding this comment.
Changed as suggested.
IntegrationTests/Services/AWSS3IntegrationTests/S3FlexibleChecksumsTests.swift
Show resolved
Hide resolved
jbelkins
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1660
Description of changes
Refer to comments on GH diff for details
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.