Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use global variable to load latest sdk-partitions file from trebuchet #1693

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

dayaffe
Copy link
Contributor

@dayaffe dayaffe commented Aug 23, 2024

Use latest sdk-partitions.json data provided by trebuchet

Issue #

#1652

Description of changes

  • Load partitions data from file rather than a static string that is manually updated
  • Use of bang (!) is acknowledged in both loading file and String conversion
  • By loading contents into a global variable the very first load may take extra time but subsequent loads should use cached version of the partitions json

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dayaffe dayaffe requested a review from jbelkins August 23, 2024 20:32
@sichanyoo sichanyoo self-requested a review August 23, 2024 20:45
@dayaffe dayaffe merged commit 766eb3f into main Aug 23, 2024
29 checks passed
@dayaffe dayaffe deleted the day/global-partition-bang branch August 23, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants