-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Account ID-based endpoints #1841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Dec 17, 2024
jbelkins
commented
Dec 17, 2024
IntegrationTests/Services/AWSDynamoDBIntegrationTests/AccountIDEndpointModeTests.swift
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
jbelkins
commented
Dec 17, 2024
jbelkins
commented
Dec 17, 2024
Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/AWSClientConfigDefaultsProvider.swift
Outdated
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Endpoints/AWSEndpointConfig.swift
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Endpoints/AccountIDEndpointMode.swift
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
...Core/AWSClientRuntime/Sources/AWSClientRuntime/Endpoints/Context+AccountIDEndpointMode.swift
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
...es/Core/AWSClientRuntime/Sources/AWSClientRuntime/Endpoints/EndpointResolverMiddleware.swift
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/UserAgent/BusinessMetrics.swift
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
Sources/Core/AWSClientRuntime/Tests/AWSClientRuntimeTests/UserAgent/BusinessMetricsTests.swift
Outdated
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
...n/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHTTPProtocolClientGenerator.kt
Outdated
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
...gen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHttpProtocolServiceClient.kt
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
...gen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHttpProtocolServiceClient.kt
Show resolved
Hide resolved
jbelkins
commented
Dec 17, 2024
...gen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHttpProtocolServiceClient.kt
Outdated
Show resolved
Hide resolved
sichanyoo
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review w/ comments about re-using extension points and removing business feature metric for ACCOUNT_ID_ENDPOINT
Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/Endpoints/Context+ResolvedEndpoint.swift
Outdated
Show resolved
Hide resolved
...es/Core/AWSClientRuntime/Sources/AWSClientRuntime/Endpoints/EndpointResolverMiddleware.swift
Outdated
Show resolved
Hide resolved
Sources/Core/AWSClientRuntime/Sources/AWSClientRuntime/UserAgent/BusinessMetrics.swift
Outdated
Show resolved
Hide resolved
...gen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHttpProtocolServiceClient.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSMiddlewareExecutionGenerator.kt
Outdated
Show resolved
Hide resolved
…ift into jbe/account_id_config
sichanyoo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
EndpointResolverMiddleware
is renamed toAWSEndpointResolverMiddleware
to make clear that it is an AWS-specialized typeAWSEndpointResolverMiddleware
is protected with Swift@_spi()
to conceal it from public usage.accountId
is no longer exposed as a client config param since it is set only via AWS credential identity resolversNote: Bump minor version when this feature ships
Also note: This is a breaking change to the DynamoDB client because client config fields have been either removed or changed in type. Expected breakage on the customer's side is zero because those fields are currently exposed but non-functional. Only DynamoDB is affected, no other client has these config fields at this time.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.