Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Account ID-based endpoints #1841

Merged
merged 38 commits into from
Jan 16, 2025
Merged

feat: Account ID-based endpoints #1841

merged 38 commits into from
Jan 16, 2025

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Dec 6, 2024

Description of changes

  • The AWS-specific EndpointResolverMiddleware is renamed to AWSEndpointResolverMiddleware to make clear that it is an AWS-specialized type
  • AWSEndpointResolverMiddleware is protected with Swift @_spi() to conceal it from public usage.
  • Endpoint params are now created by a block which can be passed into the middleware for inline evaluation, since account ID may not be known yet when endpoint params are currently constructed.
  • accountId is no longer exposed as a client config param since it is set only via AWS credential identity resolvers

Note: Bump minor version when this feature ships

Also note: This is a breaking change to the DynamoDB client because client config fields have been either removed or changed in type. Expected breakage on the customer's side is zero because those fields are currently exposed but non-functional. Only DynamoDB is affected, no other client has these config fields at this time.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Package.swift Outdated Show resolved Hide resolved
@jbelkins jbelkins marked this pull request as ready for review December 17, 2024 19:45
Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review w/ comments about re-using extension points and removing business feature metric for ACCOUNT_ID_ENDPOINT

@sichanyoo sichanyoo self-requested a review January 16, 2025 17:29
@jbelkins jbelkins merged commit ae7d140 into main Jan 16, 2025
25 checks passed
@jbelkins jbelkins deleted the jbe/account_id_config branch January 16, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants