feat: IAM auth token generator for RDS #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 24, 2024 14:07
… module instead of AWSClientRuntime module.
sichanyoo
commented
Dec 26, 2024
| @@ -0,0 +1,100 @@ | |||
| // | |||
There was a problem hiding this comment.
This is the handwritten code for token generator, located in AWSClientRuntime
| @@ -0,0 +1,63 @@ | |||
| // | |||
There was a problem hiding this comment.
This is the generated token generator located in AWSRDS that wraps AWSClientRuntime.AuthTokenGenerator; it's included in the PR as reference for reviewers on what generated output looks like.
| @@ -0,0 +1,84 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is the new codegen integration that writes a new file with wrapper token generator if service is RDS.
| @@ -26,3 +26,4 @@ software.amazon.smithy.aws.swift.codegen.AWSClientConfigurationIntegration | |||
| software.amazon.smithy.swift.codegen.swiftintegrations.InitialRequestIntegration | |||
| software.amazon.smithy.aws.swift.codegen.swiftintegrations.RegistryConfigIntegration | |||
| software.amazon.smithy.aws.swift.codegen.swiftintegrations.AmzSdkRetryHeadersIntegration | |||
| software.amazon.smithy.aws.swift.codegen.customization.rds.AuthTokenGeneratorIntegration | |||
There was a problem hiding this comment.
Makes the new integration run during codegen
dayaffe
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Changes:
AWSClientRuntime.AuthTokenGenerator. It's tagged with@_spito hide it and re-expose through AWSRDS module.AWSRDS.AuthTokenGenerator, which is a wrapper class forAWSClientRutime.AuthTokenGenerator(this is done to expose token generator via RDS module, as outlined by specifications)Tested using a dummy AWS RDS MySQL database and confirmed it works.
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.