Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Trim whitespace before parsing Version #1867

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jbelkins
Copy link
Contributor

Description of changes

  • In CLI tools, trim whitespace before parsing project version, i.e. from the Package.version and Package.version.next files.
  • Test is added to verify whitespace is successfully trimmed.

This will make the tools more forgiving when versions are inadvertently saved with whitespace, i.e. by text editors.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested review from dayaffe and sichanyoo January 14, 2025 22:02
@jbelkins jbelkins merged commit 705c7ce into main Jan 14, 2025
24 checks passed
@jbelkins jbelkins deleted the jbe/version_parsing_whitespace_fix branch January 14, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants