Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run 24x Linux integration tests on connection manager fix #1871

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −3
Draft

chore: Run 24x Linux integration tests on connection manager fix #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83fa87b
Run 24x Linux int tests
jbelkins Jan 16, 2025
0927bdb
fix yaml
jbelkins Jan 16, 2025
64b60ed
Add a failure message to transcribe streaming test
jbelkins Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/integration-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ permissions:

jobs:
apple:
if: github.repository == 'awslabs/aws-sdk-swift' || github.event_name == 'pull_request'
if: false
# if: github.repository == 'awslabs/aws-sdk-swift' || github.event_name == 'pull_request'
runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -145,6 +146,19 @@ jobs:
matrix:
os:
- jammy
n:
- 1
- 2
- 3
- 4
- 5
- 6
- 7
- 8
- 9
- 10
- 11
- 12
version:
- "5.9"
- "6.0"
Expand Down Expand Up @@ -207,4 +221,4 @@ jobs:
- name: Run Integration Tests
run: |
cd aws-sdk-swift/IntegrationTests
swift test
swift test
5 changes: 4 additions & 1 deletion ...ationTests/Services/AWSTranscribeStreamingIntegrationTests/TranscribeStreamingTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,10 @@ final class TranscribeStreamingTests: XCTestCase {
"Hello transcribed streaming from swift sdk.",
"Hello transcribes streaming from Swift SDK.",
]
XCTAssertTrue(candidates.contains(where: { $0.lowercased() == fullMessage.lowercased() }))
XCTAssertTrue(
candidates.contains { $0.lowercased() == fullMessage.lowercased() },
"The transcription \"\(fullMessage)\" does not match any of the expected forms: [\(candidates.map { "\"\($0)\"" }.joined(separator: ", "))]"
)
}

// Performs the stream transcription, with retry for selected errors associated with
Expand Down
Loading