-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable vpc endpoints for each construct #674
Conversation
Thanks @erdemayyildiz ! Overall LGTM, could you please list all the samples you deployed with your changes to validate it was working correctly ? |
hi @krokoko sure, i have fixed the build issue. the sample packages that i tested the code are;
|
LGTM, we will merge after the failing build is fixed :) |
fixed build failure. |
Are there any plans to also update the OpenSearch VectorCollection CDK construct to use "Private" as the access type (similar to the options provided in the AWS Console)? As of now when we use the CDK to create an OpenSearch VectorCollection it defaults to using the access type "Public". The new VPC helper methods created as a result of this ticket would also to create create VPC endpoints, but the underlying OpenSearch serverless collection would still be configured as "Public". |
Fixes #
Issues: #153
Enable Vpc endpoints to each construct to enable communication over private subnet of Vpc.
This change will only enable the VPC settings for the ones constructs create. Customer provided VPC will be used as provided.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.