Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable vpc endpoints for each construct #674

Merged
merged 14 commits into from
Oct 1, 2024

Conversation

erdemayyildiz
Copy link
Contributor

@erdemayyildiz erdemayyildiz commented Aug 30, 2024

Fixes #

Issues: #153

Enable Vpc endpoints to each construct to enable communication over private subnet of Vpc.
This change will only enable the VPC settings for the ones constructs create. Customer provided VPC will be used as provided.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@krokoko
Copy link
Collaborator

krokoko commented Sep 17, 2024

Thanks @erdemayyildiz ! Overall LGTM, could you please list all the samples you deployed with your changes to validate it was working correctly ?
Also, I just saw that the build was failing, could you please have a look and I'll put my review in once it is done

@erdemayyildiz
Copy link
Contributor Author

hi @krokoko

sure, i have fixed the build issue. the sample packages that i tested the code are;

  • Document Explorer
  • Open Search and Aurora Default Vector Store
  • Aurora Construct
  • Bedrock Agent

@krokoko
Copy link
Collaborator

krokoko commented Sep 30, 2024

LGTM, we will merge after the failing build is fixed :)

@erdemayyildiz
Copy link
Contributor Author

LGTM, we will merge after the failing build is fixed :)

fixed build failure.

@krokoko krokoko merged commit 00367ad into awslabs:main Oct 1, 2024
16 of 17 checks passed
@taurusnova
Copy link

Are there any plans to also update the OpenSearch VectorCollection CDK construct to use "Private" as the access type (similar to the options provided in the AWS Console)? As of now when we use the CDK to create an OpenSearch VectorCollection it defaults to using the access type "Public". The new VPC helper methods created as a result of this ticket would also to create create VPC endpoints, but the underlying OpenSearch serverless collection would still be configured as "Public".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants