Adds Remote Write changes for Prometheus

[ashishranjan738]

This commit adds changes to remote write Prometheus metrics to a AMP workspace.

Signed-off-by: Ashish Ranjan [email protected]

[mengqiy]

Why do we need this?

[ashishranjan738]

I just preferred this path as it coincides with GOPATH and also some hardcoding are there in CL2 code regarding this path https://github.com/kubernetes/perf-tests/blob/release-1.23/clusterloader2/pkg/prometheus/prometheus.go#L66. However if we are passing the manifests explicitly which indeed we are, we can avoid this. But this shouldn't be a breaking change.

[hakuna-matatah]

could you add permissions/policies required to perform AMP operations here - https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/infrastructure/lib/kit-infrastructure.ts#L129-L148 so it works out of box without manual intervention during setup.

Also, could you add a readme to setup AMP as it's a pre-req for some of our tekton pipelines in our doc here

[hakuna-matatah]

Very nice to see all this coming through. Thank you Ashish.

[ashishranjan738]

could you add permissions/policies required to perform AMP operations here - https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/infrastructure/lib/kit-infrastructure.ts#L129-L148 so it works out of box without manual intervention during setup.

@hakuna-matatah how is adding to place gonna help us ? We need this permission to the role we pass in the mng task which i guess this is currently not generated via cdk

kubernetes-iteration-toolkit/tests/tasks/setup/eks/awscli-mng.yaml

Line 28 in cf70d5c

- name: host-cluster-node-role-arn

[hakuna-matatah]

could you add permissions/policies required to perform AMP operations here - https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/infrastructure/lib/kit-infrastructure.ts#L129-L148 so it works out of box without manual intervention during setup.

@hakuna-matatah how is adding to place gonna help us ? We need this permission to the role we pass in the mng task which i guess this is currently not generated via cdk

kubernetes-iteration-toolkit/tests/tasks/setup/eks/awscli-mng.yaml

Line 28 in cf70d5c

- name: host-cluster-node-role-arn

No, tekton pods leverage IRSA hence the code link i shared in my comment will work for us if you add it there. The one you are pointing to is a node role which MNG APIs need as param for creating MNGs.

[hakuna-matatah]

could you add permissions/policies required to perform AMP operations here - https://github.com/awslabs/kubernetes-iteration-toolkit/blob/main/infrastructure/lib/kit-infrastructure.ts#L129-L148 so it works out of box without manual intervention during setup.

@hakuna-matatah how is adding to place gonna help us ? We need this permission to the role we pass in the mng task which i guess this is currently not generated via cdk

kubernetes-iteration-toolkit/tests/tasks/setup/eks/awscli-mng.yaml

Line 28 in cf70d5c

- name: host-cluster-node-role-arn

> No, tekton pods leverage IRSA hence the code link i shared in my comment will work for us if you add it there. The one you are pointing to is a node role which MNG APIs need as param for creating MNGs.

Oops accidentally closed instead of adding comment.
Synced with Ashish on this. Here in this case, prom pod on guest cluster needs access, we are going to go with node role creation tekton step/task for this and wrap all policies required inside it for guest clusters.

[hakuna-matatah]

LGTM!
/Do-not-merge

[mengqiy]

Please work with @hakuna-matatah to understand why he added /Do-not-merge in the comment above.