Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for deleting exporters #227

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Add API for deleting exporters #227

merged 4 commits into from
Jan 3, 2025

Conversation

mulmarta
Copy link
Contributor

Deleting the exporter enables forward secrecy of derived values within an epoch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner December 20, 2024 14:35
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (2af95d3) to head (f80bcf6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   90.05%   90.09%   +0.04%     
==========================================
  Files         176      176              
  Lines       31569    31590      +21     
==========================================
+ Hits        28429    28461      +32     
+ Misses       3140     3129      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tomleavy
tomleavy previously approved these changes Dec 20, 2024
stefunctional
stefunctional previously approved these changes Dec 31, 2024
Copy link
Contributor

@stefunctional stefunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some documentation nits.

mls-rs/src/group/mod.rs Outdated Show resolved Hide resolved
mls-rs/src/group/mod.rs Outdated Show resolved Hide resolved
mls-rs/src/group/mod.rs Outdated Show resolved Hide resolved
mls-rs/src/group/mod.rs Outdated Show resolved Hide resolved
@tomleavy tomleavy dismissed stale reviews from stefunctional and themself via 5992fa1 January 2, 2025 22:25
@mulmarta mulmarta merged commit 158a9d3 into main Jan 3, 2025
32 checks passed
@mulmarta mulmarta deleted the fs-exporter branch January 3, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants