-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit shared cache durations in cache hit, miss and error conditions #1162
Merged
muddyfish
merged 6 commits into
awslabs:main
from
muddyfish:shared-cache-additional-metrics
Dec 20, 2024
Merged
Emit shared cache durations in cache hit, miss and error conditions #1162
muddyfish
merged 6 commits into
awslabs:main
from
muddyfish:shared-cache-additional-metrics
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
November 22, 2024 13:44 — with
GitHub Actions
Inactive
passaro
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main concern is the return type with the additional reason. I see two possible alternatives:
- Add more specific cases to
DataCacheResult
, so you can get the "reason" from the error itself, - or emit the
express_data_cache.block_err
metric inread_block
/write_block
before returning the error.
muddyfish
force-pushed
the
shared-cache-additional-metrics
branch
from
December 6, 2024 12:47
d1bee2f
to
3705db8
Compare
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 12:47 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 6, 2024 15:42 — with
GitHub Actions
Waiting
muddyfish
force-pushed
the
shared-cache-additional-metrics
branch
from
December 6, 2024 15:46
27d29a4
to
9766e08
Compare
muddyfish
temporarily deployed
to
PR integration tests
December 6, 2024 15:46 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 6, 2024 15:46 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 6, 2024 15:46 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 6, 2024 15:46 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 6, 2024 15:46 — with
GitHub Actions
Inactive
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:06 — with
GitHub Actions
Waiting
Signed-off-by: Simon Beal <[email protected]>
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
muddyfish
requested a deployment
to
PR integration tests
December 20, 2024 15:10 — with
GitHub Actions
Waiting
Signed-off-by: Simon Beal <[email protected]>
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
muddyfish
temporarily deployed
to
PR integration tests
December 20, 2024 15:11 — with
GitHub Actions
Inactive
passaro
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional duration metrics to the shared cache for cache hits, misses, and errors.
Example metrics:
And
Additionally refactors the cache in response to comments in #1146
Does this change impact existing behavior?
Yes, the
express_data_cache.read_duration_us
metric now has a type associated with if it was a cache hit or not.Does this change need a changelog entry?
No, changes to metrics don't need changelog entries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).