Wait for CreateMPU before returning from put_object #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
passaro
force-pushed
the
async-put-object
branch
from
f204ee9 to
07b850d
Compare
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
force-pushed
the
async-put-object
branch
from
07b850d to
f9748e2
Compare
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
reviewed
Dec 17, 2024
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
monthonk
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3CrtClient::put_objectwas originally implemented so that it would complete immediately and return aPutObjectRequestimplementation. Any error from the S3 request would only be returned on callingwriteorcompleteon thePutObjectRequest. With this change, we modifyput_objectto await for the initialCreateMultipartUploadrequest to complete and only then either return aPutObjectRequestor propagate the error from the request. This is analogous to what done forget_objectin #1171 and addresses an issue where errors were not propagated correctly (#1007).At the file handle level, however, we still want the
openoperation to complete quickly, without waiting forCreateMultipartUploadto complete. In order to preserve the previous behavior,upload::atomicwas adapted to spawn a concurrent task in the background when callingput_object.Does this change impact existing behavior?
Yes.
Does this change need a changelog entry?
Yes, for
mountpoint-s3-client. No user-visible changes inmountpoint-s3.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).