[BOW-136] Refactor integration management #201
+531
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 22.65% 22.65%
=======================================
Files 90 90
Lines 3522 3522
Branches 537 537
=======================================
Hits 798 798
Misses 2724 2724 ☔ View full report in Codecov by Sentry. |
…e-integration-management
…e-integration-management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than the semi ad-hoc way we've done it up until now, have a common
IntegrationManagerclass which takes care of their lifecycle, and wrap all our integrations in that.As a nice bonus, this means that you no longer need to start Bowser after OBS/vMix or re-configure them, as Bowser will retry connecting to enabled integrations multiple times even if the first attempt fails.