Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing package name #399

Closed
wants to merge 1 commit into from

Conversation

yashb-02
Copy link

@yashb-02 yashb-02 commented Apr 25, 2024

The package attribute was missing from the <manifest> tag in AndroidManifest.xml.

This was causing an error when running the project on android.

versions:
react-native: "0.70.6"

@itxhamza
Copy link

Please review & merge this PR ASAP. I am trying to deploy my app through CI/CD process and it's giving this error there

@taboulot
Copy link
Contributor

Hi @thehood02,

Thank for the PR.
Going to check this today.
This PR has introduced the problem you are talking about. It was for handling RN 0.73 & the new gradle version. What surprised me is that I do not have the problem with RN 0.71.8.

@thehood02 & @itxhamza while waiting for me to look, use version 3.0.7 or use patch-package to unblock your situation.

@taboulot
Copy link
Contributor

Indeed I introduced a regression when merging the PR to handle AGP 8.x.
Created a new PR that handle all versions here: #401

I close this one. Going to deploy 3.0.9 in few minutes.

@taboulot taboulot closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants