Skip to content

Commit

Permalink
style(spgroup#31): remove comments
Browse files Browse the repository at this point in the history
  • Loading branch information
barbosamaatheus committed Dec 22, 2020
1 parent 7d2727a commit 1aaca69
Showing 1 changed file with 2 additions and 26 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ private boolean isInLeftStatementFLow(Statement.Type changeTag) {
return changeTag.equals(Statement.Type.SOURCE);
}

// TODO need to treat other cases
// TODO need to treat other cases (Arrays...)
// TODO add in two lists (left and right).
// TODO add depth to InstanceFieldRef and StaticFieldRef
private void gen(Statement stmt) {
Expand Down Expand Up @@ -214,6 +214,7 @@ private void checkConflicts(Unit unit, List<DataFlowAbstraction> potentialConfli
}

// TODO improve method name
// TODO need to treat other cases (Arrays...)
private boolean compareItens(ValueBox valueBox, DataFlowAbstraction dataFlowAbstraction) {
// TODO check why equivTo(Object o) doesn't work
if (valueBox.getValue() instanceof InstanceFieldRef && dataFlowAbstraction.getFieldRef() != null) {
Expand Down Expand Up @@ -275,29 +276,4 @@ private Statement createStatement(SootMethod sm, Unit u, Statement.Type changeTa
.setUnit(u).setType(changeTag).setSourceCodeLineNumber(u.getJavaSourceStartLineNumber())
.build();
}

/*private String getVariableNameInFromValueBox(ValueBox valueBox) {
if (valueBox.getValue() instanceof InstanceFieldRef) {
InstanceFieldRef instanceFieldRef = (InstanceFieldRef) valueBox.getValue();
return instanceFieldRef.getBase().toString();
} else if (valueBox.getValue() instanceof Local) {
Local local = (Local) valueBox.getValue();
return local.getName();
} else if (valueBox.getValue() instanceof StaticFieldRef) {
StaticFieldRef staticFieldRef = (StaticFieldRef) valueBox.getValue();
return staticFieldRef.getField().getName();
} else {
return "";
}
}*/
/* private String getVariableNameInDataFlowAbstraction(DataFlowAbstraction dataFlowAbstraction) {
if (dataFlowAbstraction.getLocal() != null) {
return dataFlowAbstraction.getLocal().getName();
} else if (dataFlowAbstraction.getLocalStaticRef() != null) {
return dataFlowAbstraction.getLocalStaticRef().getField().getName();
} else {
return dataFlowAbstraction.getFieldRef().getBase().toString();
}
}*/
}

0 comments on commit 1aaca69

Please sign in to comment.