Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you considered supporting context.Context in this package?
Context is widely used in many Go packages, so it seems worthwhile to add. In my case, context is necessary to pass trace ids for request tracing.
This PR is an initial stab at implementation. I mimic'd what was done for
database/sql
:There is some overlap with the existing timeout option, but having both is the more conservative option and only adds new methods to the API without breaking existing functionality.