Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.0] Automatically add function transition allow list when needed #19855

Merged

Conversation

bazel-io
Copy link
Member

If the allowlist is already present its value is respected (The package paths and label name are fixed/checked. Only repository name can be changed).

Automatically add allowlist with tools repository as defined by rule definition environment.

This fixes the incompatibility introduced in: #19493 (because whilelist is ignored and default allowlist is added)

Commit bb7fb2d

PiperOrigin-RevId: 574226941
Change-Id: If90f78a610d7bd3c107dcd94a39902c7c939aa7b

If the allowlist is already present its value is respected (The package paths and label name are fixed/checked. Only repository name can be changed).

Automatically add allowlist with tools repository as defined by rule definition environment.

This fixes the incompatibility introduced in: bazelbuild#19493 (because whilelist is ignored and default allowlist is added)

PiperOrigin-RevId: 574226941
Change-Id: If90f78a610d7bd3c107dcd94a39902c7c939aa7b
@bazel-io bazel-io requested a review from a team as a code owner October 17, 2023 22:25
@bazel-io bazel-io added awaiting-review PR is awaiting review from an assigned reviewer team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts labels Oct 17, 2023
@bazel-io bazel-io requested a review from comius October 17, 2023 22:25
@iancha1992 iancha1992 enabled auto-merge (squash) October 17, 2023 22:25
@github-actions github-actions bot added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Oct 17, 2023
@iancha1992 iancha1992 removed the team-Configurability platforms, toolchains, cquery, select(), config transitions label Oct 17, 2023
@iancha1992
Copy link
Member

cc: @fmeum

@iancha1992 iancha1992 merged commit 60f3319 into bazelbuild:release-7.0.0 Oct 18, 2023
2 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants