Copy aspect files to workspace #7202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
changed the title
LeFrosch
force-pushed
the
aspect-coping
branch
2 times, most recently
from
c65289c to
78d12ee
Compare
LeFrosch
force-pushed
the
aspect-coping
branch
6 times, most recently
from
9f748b1 to
012d8a1
Compare
github-actions
bot
added
product: CLion
mai93
approved these changes
Jan 17, 2025
LeFrosch
force-pushed
the
aspect-coping
branch
from
30482fb to
84ca923
Compare
|
rebased master |
The AspectStorageService is responsible for writing the aspect files into a directory contained in the workspace root. The AspectWriter extension allows to register writers that write individual parts of the aspect to this directory.
Bazel 5 seems to have problems with relative labels used in the aspect. This also means that the plugin is no longer compatible with Bazel 5. # Conflicts: # MODULE.bazel.lock
To ensure compatibility when executing the jars during the aspect execution, they have to be built with java 8.
LeFrosch
force-pushed
the
aspect-coping
branch
from
e34f8f7 to
c9a34d1
Compare
LeFrosch
force-pushed
the
aspect-coping
branch
from
c9a34d1 to
a92cc8e
Compare
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy all aspects into the workspace instead of using a
--override_repositoryor--inject_repositoryflag to point to the bundled aspects. This provides some benefits:--override_repository--inject_repositoryis also not requiredSince aspects need to be copied to the workspace anyway, we can now store them inside the plugin jar. This makes accessing the aspects easier, since they are not in different locations for tests and production.
Also adds aspect writing as a dedicated sync step:
