[AOSP-pick] Separate BEP fetching and parsing #7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
This is to enable independent changes to both processes. 1. Introduce a `BuildResultHelper.getBepStream()` method that knows how to get a BEP stream. Each `BuildResultHelper` gets its own implementation. 2. Re-implement other methods like `getBuildOutput()` to operate on externally supplied `BuildEventStreamProvider`. These methods should not eventually depend on a specific implementation of `BuildResultHelper` and will be moved out soon. 3. Update tests accordingly. Bug: n/a Test: existing Change-Id: I48f6cf5d19889e60c6795c1b097243cd7006c686 AOSP: 47436ebddcad73d6a5d4bf1d8ab8a8ccbe1c2235
LeFrosch
force-pushed
the
AOSP/47436ebddcad73d6a5d4bf1d8ab8a8ccbe1c2235
branch
from
d3299bf to
d50505a
Compare
ujohnny
approved these changes
Jan 29, 2025
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit 47436ebddcad73d6a5d4bf1d8ab8a8ccbe1c2235.
Separate BEP fetching and parsing
This is to enable independent changes to both processes.
Introduce a
BuildResultHelper.getBepStream()method that knowshow to get a BEP stream. Each
BuildResultHelpergets its ownimplementation.
Re-implement other methods like
getBuildOutput()to operate onexternally supplied
BuildEventStreamProvider. These methods shouldnot eventually depend on a specific implementation of
BuildResultHelperand will be moved out soon.Update tests accordingly.
Bug: n/a
Test: existing
Change-Id: I48f6cf5d19889e60c6795c1b097243cd7006c686
AOSP: 47436ebddcad73d6a5d4bf1d8ab8a8ccbe1c2235