Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Unrecognized attribute regression with bazel 8 #7254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Jan 23, 2025

Drop unrecognized attribute inspection. I have never seen a real issue found by this inspection, let's just drop it? Seems like a regression, maybe we can fix the regression, I would like to investigate a bit further.

Screenshot 2025-01-23 at 11 14 21 AM

@LeFrosch LeFrosch force-pushed the unrecoginized-attribute branch from 292c29a to 64464c7 Compare January 23, 2025 10:30
@LeFrosch LeFrosch marked this pull request as ready for review January 23, 2025 10:37
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jan 23, 2025
@LeFrosch
Copy link
Collaborator Author

LeFrosch commented Jan 23, 2025

Maybe there is also an underlying issue when using query sync. Taking a look again.

EDIT: looks like a bazel 8 regression. bazel info build-language seems to return less information with bazel 8.

@LeFrosch LeFrosch changed the title Drop unrecognized attribute inspection WIP - Unrecognized attribute regression with bazel 8 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Awaiting review from Bazel team on PRs product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants