Skip to content

Commit

Permalink
Fix the runfiles path of the subcommands of push-all.bzl
Browse files Browse the repository at this point in the history
Without this push-all silently fails because "wait" is not checking exit statuses.

I will open an issue to track that, but wanted to fix the breakage from my recent change first.
  • Loading branch information
mattmoor committed Sep 23, 2017
1 parent 6eea497 commit 1bc400d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docker/contrib/push-all.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _impl(ctx):
template = ctx.file._all_tpl,
substitutions = {
"%{push_statements}": "\n".join([
_get_runfile_path(ctx, command) + "&"
"PYTHON_RUNFILES=${RUNFILES} " + _get_runfile_path(ctx, command) + "&"
for command in scripts
]),
},
Expand Down

0 comments on commit 1bc400d

Please sign in to comment.