-
Notifications
You must be signed in to change notification settings - Fork 691
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding Basic Support for Windows Docker Images (#493)
container_import Added a parameter called “manifest”. This allows Bazel to import a Windows base image without checking in GBs of tar files. All that is needed is the config and manifest files from the base Windows image. The layers parameter should be an empty list. container_import( name = "windowsservercore_1803", config = "windowsservercore.1803.config.json", manifest = "windowsservercore.1803.manifest.json", layers = [] ) container_image Added an optional parameter to docker_build called “operating_system.” While most of the changes are foreign layer specific, two changes were required to address Windows specifically. There is no support for adding registry diffs, but diffs in existing layers will be respected and continue to work. container_image( name = "basic_windows_image", base = ":import_windows_base_image", cmd = ['bar.exe'], files = [":bar.exe"] operating_system = "windows", ) * Adding basic support for Windows Docker images. Does not support adding new registry delta's, but will work with base images that already have registry deltas. * Changing container_import to use application/vnd.docker.distribution.manifest.v2+json instead of application/vnd.docker.distribution.manifest.list.v2+json as the input. * Using archive.py from http_archive. To be removed when bazel 0.17,0 is released
- Loading branch information
Showing
16 changed files
with
435 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.