Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux ppc64le binaries for puller and loader #1923

Closed
wants to merge 1 commit into from

Conversation

MatthieuSarter
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may conflict with WIP to build the puller and pusher as part of our releases rather than on the separate pipeline

@@ -126,6 +126,38 @@ steps:
id: "push-loader-linux-s390x"
waitFor: ["build-linux-s390x"]

# Step: build the puller and pusher release binary for Linux ppc64le
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comment that Alex left, CloudBuild is currently disabled for this repo.

@MatthieuSarter
Copy link
Author

MatthieuSarter commented Aug 20, 2021

I think this may conflict with WIP to build the puller and pusher as part of our releases rather than on the separate pipeline

Right ! Sorry I missed it.

@alexeagle
Copy link
Collaborator

let's work in #1918 instead - we should make sure it has all the os/arch combos that users need

@alexeagle alexeagle closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants