Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental load support for commit and extract. #2208

Closed
wants to merge 4 commits into from

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Jan 11, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

container_run_and_commit and container_run_and_extract don't support the intermediate format because they were moved from https://github.com/GoogleContainerTools/base-images-docker.

Issue Number: 1384

What is the new behavior?

Support incremental loading in the two rules so that they can depend on container_image rules' layer outputs instead of having to depend on the image tarball.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

More context in the previous attempt: #1439.

Signed-off-by: Thomas Lam <[email protected]>
@google-cla
Copy link

google-cla bot commented Jan 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@uri-canva
Copy link
Contributor Author

Sorry to ask this of you @uhthomas but given the effort put into #1439 that didn't pan out I'm hesitant to spend more time on this, can you take this over?

@lamcw looks like the CLA check is failing because you're the author of the commit, can you submit one via https://cla.developers.google.com?

@uhthomas
Copy link
Collaborator

I understand @uri-canva, no worries. I can't guarantee I'll get round to it though I appreciate you making the effort to update this PR with your latest changes.

lamcw added 3 commits January 19, 2023 11:14
Signed-off-by: Thomas Lam <[email protected]>
Signed-off-by: Thomas Lam <[email protected]>
Signed-off-by: Thomas Lam <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Sep 4, 2023
@uri-canva uri-canva closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants