Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty string as fallback value for undefined environment variables #2261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use empty string as fallback value for undefined environment variables #2261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/dockerfile_build.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _impl(repository_ctx):
build_args.extend(["--build-arg", "%s=%s" % (pair[0], pair[1])])
if repository_ctx.attr.vars:
for env_var in repository_ctx.attr.vars:
build_args.extend(["--build-arg", "%s=%s" % (env_var, repository_ctx.os.environ.get(env_var))])
build_args.extend(["--build-arg", "%s=%s" % (env_var, repository_ctx.os.environ.get(env_var, ""))])

# The docker bulid command needs to run using the supplied Dockerfile
# because it may refer to relative paths in its ADD, COPY and WORKDIR
Expand Down