refactor(pypi): rename config settings and improve docs #2556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR the
config_setting
names where following an internallogic and those names would be leaking into the error messages when no
match is found. I thought that the names thus should be improved and
maybe made more similar to the
whl
filename parts that they arederived from.
As part of this change I have also added more docs and added them to
sphinxdocs in the hopes that this documentation helps maintainers and
users looking at error messages alike.
Summary:
osx_<cpu>_universal2
config settings for eachcpu
value, have a singleosx_universal2
config setting._dist_config_setting
code to be simpler and createfewer targets by using a clever trick for the
whl
config settingflag value usage.
The stats:
Work towards #260