-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify behavior of load statement #180
Open
stepancheg
wants to merge
1
commit into
bazelbuild:master
Choose a base branch
from
stepancheg:load
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2903,6 +2903,40 @@ load("module.sky", "x", "y", "z") # assigns x, y, and z | |
load("module.sky", "x", y2="y", "z") # assigns x, y2, and z | ||
``` | ||
|
||
Varaibles bound by `load` statement are local to the current module: | ||
they are not available to `load` statements from other modules even | ||
if variable names do not start with an underscore. Loaded variables | ||
are similar to builtins: they are available to the current module | ||
but they cannot be loaded unless they are explicitly reassigned to | ||
globals. | ||
|
||
Loaded variables cannot be rebound, similar to global variables: | ||
* it is a static error to bind a variable more than once with load statements | ||
* it a static or runtime error to bind a global variable if a variable | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we drop "or runtime"? |
||
with the same name name previously loaded | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "name name" => "name was" |
||
* it is permitted to load a variable overriding a builtin | ||
|
||
For example, this code is incorrect: | ||
|
||
```python | ||
load("module.sky", "x") | ||
load("module2.sky", "x") # error: variable x is already bound | ||
``` | ||
|
||
This code is incorrect as well: | ||
|
||
```python | ||
load("module.sky", "x") | ||
def x(): pass # error: variable x is already bound | ||
``` | ||
|
||
This code is fine: | ||
|
||
```python | ||
load("module.sky", True = "BetterTrue") | ||
``` | ||
|
||
|
||
A load statement within a function is a static error. | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables