Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tauri, just a demo, don't merge #140

Closed
wants to merge 3 commits into from
Closed

Tauri, just a demo, don't merge #140

wants to merge 3 commits into from

Conversation

kklem0
Copy link
Collaborator

@kklem0 kklem0 commented Jun 12, 2023

It creates a 5 MB desktop app with 30 MB memory usage, also mobile if you use tauri beta.

@SimonSimCity
Copy link
Collaborator

Could you add or link some resources of how this could be tested? We're well on our way of integrating electron, but if Tauri is well enough and we can integrate and build it, why not spend more time looking into it and drop electron ..?

@SimonSimCity
Copy link
Collaborator

Seems Tauri doesn't seem to support deep-links ... Does this mean, it would not be easy to have the login process in the browser?

@kklem0
Copy link
Collaborator Author

kklem0 commented Jun 15, 2023

Seems Tauri doesn't seem to support deep-links ... Does this mean, it would not be easy to have the login process in the browser?

So you need to use https://github.com/FabianLars/tauri-plugin-deep-link and to intercept external traffic similar to Electron. So you need to open the auth page with shell.open(), need to write a simple rust program for that, then deep link it back with their API. It's basically the same thing as Electron but in Rust.

But I'm wondering if we could implement the login process same as BANK ID in Norway which is using an iframe instead of browser.

Screenshot 2023-06-15 at 14 55 58

Or https://auth0.com/docs/authenticate/login/embedded-login ?

@kklem0
Copy link
Collaborator Author

kklem0 commented Jun 15, 2023

Could you add or link some resources of how this could be tested? We're well on our way of integrating electron, but if Tauri is well enough and we can integrate and build it, why not spend more time looking into it and drop electron ..?

To me it never hurts to try new tech and be open to new things, a few new things that I'm using these days started using Tauri and I can see the much smaller package size with decent performance, so it's nice to have a project to test it out. It works with bmm-web for now but not auth, I injected the auth token in to make it work, but I can see other projects made it work with 3rd party plugin with deep linking so it's nice to test it out. I'll take another look at it this weekend.

@SimonSimCity
Copy link
Collaborator

Well, we had it earlier that the login process is fully handled by the electron app, but we had troubles with the google login. Since credentials are anyways usually easily accessible in the browser, we chose to take the step and integrated the system default browser into the login process. You could also simply have it different. There's also other methods for logging in (see /app.vue which has the method loginWithRedirect()) ... Having it in the browser just feels that the user can use all completion-additions and password-managers he's already so used to 🤗

@kkuepper
Copy link
Member

kkuepper commented Sep 15, 2023

Nothing has happened for several months so I'm closing it

@kkuepper kkuepper closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants