Test and fix conversion of EdDSA keys with leading zero #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
force-pushed
the
ed_leading_zero
branch
2 times, most recently
from
47ca97b to
f169c1f
Compare
Closed
vanitasvitae
force-pushed
the
ed_leading_zero
branch
from
f169c1f to
7f286f8
Compare
|
I added a test for an Ed25519 key with a leading 0 as well. |
vanitasvitae
changed the title
vanitasvitae
commented
Jun 2, 2024
pg/src/main/java/org/bouncycastle/openpgp/operator/jcajce/JcaPGPKeyConverter.java
Show resolved
Hide resolved
|
This makes sense. Merged! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a test and a patch for conversion of Ed25519, Ed448 keys which have a leading 0 in their encoding.
Fixes #1690