Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-1791 Replaced-display-name-ministry-to-Organization #1602

Merged
merged 12 commits into from
Feb 13, 2025

Conversation

revanth-banala
Copy link
Collaborator

@revanth-banala revanth-banala commented Feb 11, 2025

Description

In the CHEFS FormProfile section,
previously we used to have default placeholder as ministry but now we are adding central agencies to that list so I have updated the word to Organization and also updated the error message displayed also.

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

return Ministries.map((ministry) => ({
id: ministry.id,
text: t(`trans.ministries.${ministry.id}`),
return Ministries.map((Organization) => ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change doesnt have any effect though since the Organization or ministry is just a temp variable

@revanth-banala revanth-banala merged commit 50468af into bcgov:main Feb 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants