Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FORMS-1706 Updated vitest dependencies to v2.1.9 #1605

Merged
merged 7 commits into from
Feb 15, 2025

Conversation

revanth-banala
Copy link
Collaborator

Description

Our frontend test suite is out of date and should be updated. The vitest version is 0.32.2, which was released 2023-06-13. An attempt was made to update to the new v3 of vitest but there was a large number of test failures. Instead update to v2, which had a fewer number of failures.

Acceptance Criteria

We are updated to vitest v2.1.9

The tests all pass

Type of Change

build (change in build system or dependencies)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@revanth-banala
Copy link
Collaborator Author

I have updated the vitest to the v2.1.9 but 3 tests are failed, so not sure how to fix this I might need someone's help who is reviewing it.

@WalterMoar

This comment was marked as resolved.

@revanth-banala revanth-banala marked this pull request as ready for review February 13, 2025 20:58
Copy link
Collaborator

@WalterMoar WalterMoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@revanth-banala revanth-banala merged commit 7ef87af into bcgov:main Feb 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants