-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-1706 Updated vitest dependencies to v2.1.9 #1605
Merged
revanth-banala
merged 7 commits into
bcgov:main
from
revanth-banala:update-vitest-dependency
Feb 15, 2025
Merged
FORMS-1706 Updated vitest dependencies to v2.1.9 #1605
revanth-banala
merged 7 commits into
bcgov:main
from
revanth-banala:update-vitest-dependency
Feb 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have updated the vitest to the v2.1.9 but 3 tests are failed, so not sure how to fix this I might need someone's help who is reviewing it. |
This comment was marked as resolved.
This comment was marked as resolved.
WalterMoar
reviewed
Feb 13, 2025
|
WalterMoar
approved these changes
Feb 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our frontend test suite is out of date and should be updated. The vitest version is 0.32.2, which was released 2023-06-13. An attempt was made to update to the new v3 of vitest but there was a large number of test failures. Instead update to v2, which had a fewer number of failures.
Acceptance Criteria
We are updated to vitest v2.1.9
The tests all pass
Type of Change
build (change in build system or dependencies)
Checklist
Further comments