Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build warnings with certain feature combinations #17009

Closed
BenjaminBrienen opened this issue Dec 28, 2024 · 0 comments · Fixed by #17011
Closed

Build warnings with certain feature combinations #17009

BenjaminBrienen opened this issue Dec 28, 2024 · 0 comments · Fixed by #17011
Assignees
@BenjaminBrienen
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented Dec 28, 2024 •
edited
Loading

In CI, we don't use warnings as errors in all relevant places, so warnings are found, but don't block merging. These warnings should be fixed and the CI should fail on warnings.

https://github.com/bevyengine/bevy/actions/runs/12519981025/job/34925080257#step:5:25

https://doc.rust-lang.org/stable/clippy/continuous_integration/index.html
@BenjaminBrienen BenjaminBrienen added A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Dec 28, 2024
@BenjaminBrienen BenjaminBrienen self-assigned this Dec 28, 2024
@BenjaminBrienen BenjaminBrienen mentioned this issue Dec 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 31, 2024
@BenjaminBrienen
Use -D warnings in all relevant CI (#17011)
4460a4d 
# Objective

Fixes #17009

See:
https://doc.rust-lang.org/stable/clippy/continuous_integration/index.html

## Solution

Add the env

## Testing

CI should start to fail, then I'll fix it.

## Showcase


![image](https://github.com/user-attachments/assets/acd2888f-9fc0-445a-a96a-842ba9f1c6aa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use -D warnings in all relevant CI BenjaminBrienen/bevy
1 participant
@BenjaminBrienen