You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve lighthouse finding around above-the-fold image being loaded lazily; prioritizing just the first image is enough to eliminate the finding and maps to the mobile experience where you can only see one image. On desktop this might ideally be more like the first 3-4 images, but the finding on desktop goes away also so I'm fine to start with 1 image.
* chore(core): use next canary and enable ppr
* fix: use suggested functions over deprecated ones
* chore(core): update tailwind config and layout to use Soul config
* fix: eslint issues
* chore(core): add roboto mono font
* chore(core): add @/vibes/* path in tsconfig
* feat(core): add FeaturedProductsList component and use in Homepage (#1673)
* feat(core): add FeaturedProductsCarousel and use in Homepage (#1675)
* feat(core): add best selling products to Hompage (#1676)
* chore: bump components to include latest Streamable util (#1681)
* chore(core): use next canary and enable ppr
* feat: replace catalyst homepage slideshow
* refactor: updated slideshow structure based on PR feedback
* feat: add translations for homepage slider
* fix: slide not in view when element inside is focused
---------
Co-authored-by: Jorge Moya <[email protected]>
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bookernath
force-pushed
the
plp-image-priority
branch
from
What/Why?
Improve lighthouse finding around above-the-fold image being loaded lazily; prioritizing just the first image is enough to eliminate the finding and maps to the mobile experience where you can only see one image. On desktop this might ideally be more like the first 3-4 images, but the finding on desktop goes away also so I'm fine to start with 1 image.
Testing
Before:
After (finding gone):