Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1780 Content that functions as a list should be indicated as such to screen reader users #2429

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

bc-vlad-dlogush
Copy link
Contributor

@bc-vlad-dlogush bc-vlad-dlogush commented Feb 14, 2024

What?

This PR makes payment images as a list in order to meet WCAG 2.0 Level A

Tickets / Documentation

Screenshots / Screen Recording

before.mov
after.mov

@bc-vlad-dlogush bc-vlad-dlogush force-pushed the BCTHEME-1780 branch 2 times, most recently from 7733aa3 to aeb4a9f Compare February 16, 2024 09:54
Copy link
Contributor

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-vlad-dlogush bc-vlad-dlogush force-pushed the BCTHEME-1780 branch 2 times, most recently from 164f43d to 09080d5 Compare March 4, 2024 11:44
… be indicated as such to screen reader users
@bc-vlad-dlogush bc-vlad-dlogush merged commit 8077da1 into master Mar 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants