-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storefront): BCTHEME-1780 Content that functions as a list should be indicated as such to screen reader users #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-vlad-dlogush
force-pushed
the
BCTHEME-1780
branch
from
February 14, 2024 12:35
8735fc9
to
273c19d
Compare
yurytut1993
reviewed
Feb 14, 2024
yurytut1993
reviewed
Feb 14, 2024
bc-vlad-dlogush
force-pushed
the
BCTHEME-1780
branch
2 times, most recently
from
February 16, 2024 09:54
7733aa3
to
aeb4a9f
Compare
yurytut1993
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bc-yevhenii-buliuk
approved these changes
Feb 26, 2024
bc-vlad-dlogush
force-pushed
the
BCTHEME-1780
branch
from
March 1, 2024 12:04
aeb4a9f
to
4a22453
Compare
bc-yevhenii-buliuk
approved these changes
Mar 1, 2024
bc-vlad-dlogush
force-pushed
the
BCTHEME-1780
branch
from
March 1, 2024 12:35
4a22453
to
7f474e8
Compare
yurytut1993
reviewed
Mar 4, 2024
bc-vlad-dlogush
force-pushed
the
BCTHEME-1780
branch
2 times, most recently
from
March 4, 2024 11:44
164f43d
to
09080d5
Compare
… be indicated as such to screen reader users
bc-vlad-dlogush
force-pushed
the
BCTHEME-1780
branch
from
March 4, 2024 11:46
09080d5
to
78b934d
Compare
yurytut1993
approved these changes
Mar 4, 2024
bc-azvierieva
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes payment images as a list in order to meet WCAG 2.0 Level A
Tickets / Documentation
Screenshots / Screen Recording
before.mov
after.mov