fix(storefront): BCTHEME-1778 Decorative SVG elements should be hidden from screen reader users #2432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from screen reader users
|
@bc-vlad-dlogush Could you add a screen recordings before and after the changes? |
|
@bc-yevhenii-buliuk added |
bc-yevhenii-buliuk
approved these changes
Feb 21, 2024
bc-azvierieva
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds attribute aria-hidden="true" to the decorative SVG tag to ignore voiced the text by using screen reader. In order to meet WCAG 2.0 Level A. More details are described in the ticket
Tickets / Documentation
Screenshots / Screen Recording
before.mov
after.mov