fix(storefront): BCTHEME-1768 ADA Compliance - Accordion buttons are not read by screen reader correctly #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-vlad-dlogush
approved these changes
Mar 6, 2024
BC-krasnoshapka
approved these changes
Mar 11, 2024
yurytut1993
reviewed
Mar 11, 2024
yurytut1993
reviewed
Mar 11, 2024
…not read by screen reader correctly
bc-yevhenii-buliuk
force-pushed
the
BCTHEME-1768
branch
from
b46ba91 to
41ec94a
Compare
yurytut1993
approved these changes
Mar 11, 2024
bc-azvierieva
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the
<h2>tags that serves as the accordion headers.Tickets / Documentation
Screen Recording
before:
1768_before.mov
after:
1768_after.mov