Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sd): SD-10679 Adds nonce to Checkout and MyAccount pages #2525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jkanive
Copy link

@jkanive jkanive commented Dec 18, 2024

What?

Adds nonce handlebar to script tags on Checkout and Accounts pages.
A description about what this pull request implements and its purpose. Try to be detailed and describe any technical details to simplify the job of the reviewer and the individual on production support.

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Checkout Page

Screenshot 2024-12-23 at 5 42 05 PM Screenshot 2024-12-23 at 5 43 24 PM Screenshot 2024-12-23 at 5 41 19 PM

My Accounts Page

Screenshot 2024-12-23 at 5 39 02 PM Screenshot 2024-12-23 at 5 39 40 PM Screenshot 2024-12-23 at 5 38 28 PM

@jkanive jkanive marked this pull request as ready for review December 24, 2024 01:45
@bc-alexsaiannyi
Copy link
Contributor

hey @jkanive. Looks good, add please a line to CHANGELOG.md, something like:

  • Add nonce to checkout and account pages #2525

@jkanive jkanive force-pushed the nonce branch 2 times, most recently from 19eeac9 to 73a0639 Compare January 3, 2025 22:05
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants